Skip to content

Update pr.yml workflow to include compiled firmware in build artifacts #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haslinghuis merged 1 commit into from
Jan 11, 2026
Merged

Update pr.yml workflow to include compiled firmware in build artifacts #1006

haslinghuis merged 1 commit into from
Jan 11, 2026

Conversation

@ot0tot
Copy link
Contributor

@ot0tot ot0tot commented Jan 8, 2026 •
edited by coderabbitai bot
Loading

Small addition to the workflow to make the compiled firmware available for testing.

Summary by CodeRabbit

  • New Features
    • Firmware artifacts are now automatically uploaded and available for download after successful builds.
    • Artifacts are grouped per build target and retained for 30 days.
    • The build will emit a warning if no firmware files are produced for a target.

✏️ Tip: You can customize this high-level summary in your review settings.

@ot0tot ot0tot requested a review from blckmn January 8, 2026 15:29
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026 •
edited
Loading

Caution

Review failed

Failed to post review comments

Walkthrough

Adds a new "Upload Firmware Artifact" step to the GitHub Actions PR workflow matrix build job to upload compiled hex files from betaflight/obj/*.hex as artifacts with a 30-day retention.

Changes

Cohort / File(s) Summary
GitHub Actions workflow
\.github/workflows/pr\.yml		 Add "Upload Firmware Artifact" step using actions/upload-artifact@v4 to upload betaflight/obj/*.hex as firmware-${{ matrix.target }}, retain 30 days, warn if no files found.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • nerdCopter
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is vague and generic; it does not follow the required template structure with mandatory sections like hardware compliance, checklist, or proper housekeeping details. Replace the generic description with the required template structure, including hardware compliance sections, checklist items, and proper documentation relevant to the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding compiled firmware to build artifacts in the PR workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ot0tot ot0tot requested a review from haslinghuis January 8, 2026 15:29
@haslinghuis haslinghuis requested a review from nerdCopter January 8, 2026 16:59
@haslinghuis
Copy link
Member

haslinghuis commented Jan 8, 2026

@CodeRabbit review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@haslinghuis
Copy link
Member

haslinghuis commented Jan 8, 2026

@coderabbitai approve

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

✅ Actions performed

Comments resolved and changes approved.

@haslinghuis haslinghuis merged commit 8c27ef5 into master Jan 11, 2026
2 checks passed
@haslinghuis haslinghuis deleted the ot0tot-patch-3 branch January 11, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@blckmn blckmn Awaiting requested review from blckmn

Assignees

@ot0tot ot0tot

Labels

Housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ot0tot @haslinghuis @nerdCopter